[Kstars-devel] Review Request 113936: [GCI] Remove "No Equipment" option from settings dialog in "What's Interesting"
Samikshan Bairagya
samikshan at gmail.com
Tue Nov 19 11:40:13 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113936/#review43933
-----------------------------------------------------------
I think you need to make some changes to the kstars.kcfg file as well which you have forgotten. Otherwise this works fine.
- Samikshan Bairagya
On Nov. 19, 2013, 11:01 a.m., Jai Luthra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113936/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 11:01 a.m.)
>
>
> Review request for KStars and Samikshan Bairagya.
>
>
> Repository: kstars
>
>
> Description
> -------
>
> GCI TASK: Remove "No Equipment" from settings dialog for What's Interesting feature.
> https://www.google-melange.com/gci/task/view/google/gci2013/5783794355273728
>
>
> Diffs
> -----
>
> kstars/tools/whatsinteresting/wiequipsettings.h 24ec59b
> kstars/tools/whatsinteresting/wiequipsettings.cpp 84214ab
> kstars/tools/whatsinteresting/wiequipsettings.ui ba137e5
>
> Diff: http://git.reviewboard.kde.org/r/113936/diff/
>
>
> Testing
> -------
>
> Compiles and runs as expected.
>
>
> Thanks,
>
> Jai Luthra
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131119/27c9b891/attachment.html>
More information about the Kstars-devel
mailing list