[Kstars-devel] Review Request 110365: Make satellite group names translatable
Commit Hook
null at kde.org
Mon May 13 00:42:54 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110365/#review32411
-----------------------------------------------------------
This review has been submitted with commit 39846dd7072cdd4452b5b4795c0d54f896ce496a by Akarsh Simha on behalf of Yuri Chornoivan to branch bleeding-edge.
- Commit Hook
On May 10, 2013, 10:13 a.m., Yuri Chornoivan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110365/
> -----------------------------------------------------------
>
> (Updated May 10, 2013, 10:13 a.m.)
>
>
> Review request for KStars and Albert Astals Cid.
>
>
> Description
> -------
>
> The names of satellite groups are not extracted from data/satellites.dat and their translations (should they are added to kstars.po) are not loaded into Settings window.
>
> Steps to Reproduce:
> 1. Start KStars with any locale (e.g. x-test)
> 2. Choose Settings -> Configure KStars... -> Satellites
>
> This patch tries to fix this issue.
>
> Updated to parse data/satellites.dat directly with scripty.
>
>
> This addresses bug 318598.
> http://bugs.kde.org/show_bug.cgi?id=318598
>
>
> Diffs
> -----
>
> kstars/Messages.sh d828340
> kstars/data/satellites.dat 835b6f0
> kstars/options/opssatellites.cpp c9da881
>
> Diff: http://git.reviewboard.kde.org/r/110365/diff/
>
>
> Testing
> -------
>
> Tested with Ukrainian locale: extraction -> translation -> catalog loading. Works as expected, screenshot: https://dl.dropboxusercontent.com/u/55247264/sat_trans.png
>
>
> Thanks,
>
> Yuri Chornoivan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130513/07e90d47/attachment.html>
More information about the Kstars-devel
mailing list