[Kstars-devel] Review Request 110365: Make satellite group names translatable

Yuri Chornoivan yurchor at ukr.net
Wed May 8 18:35:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110365/
-----------------------------------------------------------

(Updated May 8, 2013, 6:35 p.m.)


Status
------

This change has been discarded.


Review request for KStars and Albert Astals Cid.


Description
-------

The names of satellite groups are not extracted from data/satellites.dat and their translations (should they are added to kstars.po) are not loaded into Settings window.

Steps to Reproduce:
1. Start KStars with any locale (e.g. x-test)
2. Choose Settings -> Configure KStars... -> Satellites

This patch tries to fix this issue.


This addresses bug 318598.
    http://bugs.kde.org/show_bug.cgi?id=318598


Diffs
-----

  kstars/options/opssatellites.cpp c9da881 
  kstars/satgroup_strings.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110365/diff/


Testing
-------

Tested with Ukrainian locale and one group name translated ("Last Launches"). Works as expected, screenshot: https://dl.dropboxusercontent.com/u/55247264/sat_trans.png


Thanks,

Yuri Chornoivan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130508/2968458f/attachment.html>


More information about the Kstars-devel mailing list