[Kstars-devel] Review Request 111174: Don't recompile the regex on every call of re.sub

Aneesh Dogra lionaneesh at gmail.com
Sat Jun 22 11:37:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111174/
-----------------------------------------------------------

Review request for KStars and Henry de Valence.


Description
-------

Everytime the parse function is used. The call to re.sub will recompile the "<.*?>" regex. The patch uses a variable to save the compiled version of "<.*?>" and passing the compiled regex to the parse function.


Diffs
-----

  kstars/data/scripts/supernova_updates_parser.py 552e428 

Diff: http://git.reviewboard.kde.org/r/111174/diff/


Testing
-------


Thanks,

Aneesh Dogra

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130622/a64aebe7/attachment.html>


More information about the Kstars-devel mailing list