[Kstars-devel] Review Request 110971: Disable "Automatically select coordinate grid" when the user manually toggles equatorial or horizontal coordinate grids.

Henry de Valence hdevalence at gmail.com
Sun Jun 16 04:58:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110971/#review34406
-----------------------------------------------------------

Ship it!


Ship It!

- Henry de Valence


On June 13, 2013, 1:26 p.m., Aneesh Dogra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110971/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 1:26 p.m.)
> 
> 
> Review request for KStars.
> 
> 
> Description
> -------
> 
> I think if the user is asking to display the equatorial/horizontal grid we should just disable "Automatically select coordinate grid" and do what he wants. I don't really think disabling the buttons or showing the user a warning of some sort is the correct solution to this issue. Its like saying "Hey user you asked Kstars to automatically set the coordinate grids for you, but now you are yourself fiddling with the settings, that's not good, please go do 1, 2, 3". I am open to discussions, though. Thanks for taking time to review this.
> 
> 
> This addresses bug 321027.
>     http://bugs.kde.org/show_bug.cgi?id=321027
> 
> 
> Diffs
> -----
> 
>   kstars/kstarsactions.cpp 1ed783e 
> 
> Diff: http://git.reviewboard.kde.org/r/110971/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aneesh Dogra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130616/4daf226b/attachment.html>


More information about the Kstars-devel mailing list