[Kstars-devel] Review Request 110987: Add a private method centerOnPlanet in SkyMap to encapsulate all the common code in [key_0..key_9].

[Henry de Valence]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110987/#review34260
-----------------------------------------------------------

Ship it!


This looks good to me. I don't think that inlining things is really necessary here, though, since the function is not performance-sensitive.

- Henry de Valence


On June 13, 2013, 7:41 a.m., Aneesh Dogra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110987/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 7:41 a.m.)
> 
> 
> Review request for KStars.
> 
> 
> Description
> -------
> 
> Encapsulation patch.
> 
> 
> Diffs
> -----
> 
>   kstars/skymap.h dd67cd8 
>   kstars/skymapevents.cpp 9cfbb8d 
> 
> Diff: http://git.reviewboard.kde.org/r/110987/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aneesh Dogra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130613/36ce92cf/attachment-0001.html>