[Kstars-devel] Review Request 110973: Update the local time before we update the timebox.

[Rishab Arora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110973/#review34238
-----------------------------------------------------------

Ship it!


Solves the issue. This fix relies on changing the order of connecting slots.

- Rishab Arora


On June 12, 2013, 12:55 p.m., Aneesh Dogra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110973/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 12:55 p.m.)
> 
> 
> Review request for KStars.
> 
> 
> Description
> -------
> 
> The time in the timebox lags by one step when the user advances one step backward/forward in time. The happens because the timebox updater function and local time updater function are connected with the same signal i.e timeChanged. The order of connection to this signal is reversed. We first connect the timebox updater and then the local time updater. This causes the timebox to be updated before the local time; hence, causing the lag. The patch simply uses the correct order, i.e connects the local time updater to the signal before it connects the timebox. This ensures that local time gets updated before the timebox.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=321028.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=321028
> 
> 
> Diffs
> -----
> 
>   kstars/kstarsinit.cpp f89bedd 
> 
> Diff: http://git.reviewboard.kde.org/r/110973/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aneesh Dogra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130612/ee17cd15/attachment.html>