[Kstars-devel] Review Request 104329: some fixme issues tackled

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104329/#review26989
-----------------------------------------------------------


KStars guys, did you ever get to review this?

- Albert Astals Cid


On March 18, 2012, 7:18 a.m., Vageesh DC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104329/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 7:18 a.m.)
> 
> 
> Review request for KStars, Akarsh Simha and Rafal Kulaga.
> 
> 
> Description
> -------
> 
> the following were incorporated:
> 1.making  SkyPoint::updateCoords() faster
> 2.div by zero handling in SkyPoint::SkyPoint()
> 3. drawing clipped line in void SkyGLPainter::drawSkyLine()
> 
> 
> Diffs
> -----
> 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyglpainter.cpp 2a74af9 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyobjects/skypoint.cpp 19feb91 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyobjects/starobject.cpp a35ccd6 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyqpainter.cpp 43f06e8 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/tools/observinglist.cpp 3d4ac99 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/kstarsui.rc 9ee4b0e 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skycomponents/linelistlabel.cpp 0be66e4 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skycomponents/skymapcomposite.cpp 8b83c08 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/kstarsinit.cpp bbc70fe 
> 
> Diff: http://git.reviewboard.kde.org/r/104329/diff/
> 
> 
> Testing
> -------
> 
> tested all.no build issues
> 
> 
> Thanks,
> 
> Vageesh DC
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130208/9a13b0a6/attachment.html>