[Kstars-devel] Review Request 112496: Column for Object 2 is added in conjunctions tool and default width of column is set larger

[Albert Astals Cid]

El Diumenge, 29 de desembre de 2013, a les 22:47:27, Vijay Dhameliya va 
escriure:
> > On Sept. 14, 2013, 9:17 p.m., Rafal Kulaga wrote:
> > > kstars/tools/conjunctions.cpp, line 387
> > > <https://git.reviewboard.kde.org/r/112496/diff/4/?file=189402#file189402
> > > line387>> > 
> > >     Stray WS
> 
> Changes are made accordingly, now :)

Are they? I still see "const QString object2" instead of "const QString 
&object2" as suggested.

Cheers,
  Albert

> 
> 
> - Vijay
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112496/#review40031
> -----------------------------------------------------------
> 
> On Sept. 29, 2013, 6:22 a.m., Vijay Dhameliya wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/112496/
> > -----------------------------------------------------------
> > 
> > (Updated Sept. 29, 2013, 6:22 a.m.)
> > 
> > 
> > Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and
> > Rafal Kulaga.
> > 
> > 
> > Repository: kstars
> > 
> > 
> > Description
> > -------
> > 
> > In conjunctions tool default width of column in text box is set large
> > enough to make it look better and column "object 2" is added to keep log
> > of to which object the object 1 is mapping,  when we have calculated many
> > conjunctions from same object 1 to different object 2s.
> > 
> > 
> > Diffs
> > -----
> > 
> >   kstars/kstarsinit.cpp a4393e6
> >   kstars/tools/conjunctions.h b51209e
> >   kstars/tools/conjunctions.cpp 39cef00
> >   kstars/tools/conjunctions.ui 80374b1
> > 
> > Diff: https://git.reviewboard.kde.org/r/112496/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > tested
> > 
> > 
> > File Attachments
> > ----------------
> > 
> >   https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunct
> >   ion_tool_after.png
> >   
> >   https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunct
> >   ion_tool_Before.png> 
> > Thanks,
> > 
> > Vijay Dhameliya