[Kstars-devel] Review Request 114348: Correct parsing of google image search file for images in detail of skyobject

Rafal Kulaga rl.kulaga at gmail.com
Sat Dec 21 23:55:05 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114348/#review46022
-----------------------------------------------------------

Ship it!


Ship it!

- Rafal Kulaga


On Dec. 7, 2013, 8:39 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114348/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2013, 8:39 p.m.)
> 
> 
> Review request for KStars and Rafal Kulaga.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Issue: while clicking on thumbnail of image in detail dialogue box of skyobject who does not have any picture link in database does not download images from Google due to wrong method of parsing. 
> 
> 
> Diffs
> -----
> 
>   kstars/thumbnailpicker.cpp d3b3cce 
> 
> Diff: http://git.reviewboard.kde.org/r/114348/diff/
> 
> 
> Testing
> -------
> 
> Downloaded images are very small in size but small images instead of nothing are better :) 
> 
> 
> File Attachments
> ----------------
> 
> comet_image_loader.png
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/12/07/12a171be-c942-4cec-9ff7-5e532a59e192__comet_image_loader.png
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131221/02873ce9/attachment.html>


More information about the Kstars-devel mailing list