[Kstars-devel] Review Request 113019: Update moon position code to Meeus 1998 and fixed bug in Time calculator->Almanac

[Rafal Kulaga]

> On Dec. 7, 2013, 5:53 p.m., Rafal Kulaga wrote:
> > Ship it, but I think it would make sense to use pow() instead of series of multiplication operators.
> 
> Aleksey Khudyakov wrote:
>     I would expect pow to be much slower than multiplication. Also to my knowledge most efficient method for evaluation of polynomials is Horner's algorithm. http://en.wikipedia.org/wiki/Horner%27s_method

Well, I'd expect that too, but I was considering it more from the readability perspective ;-) Anyway, an interesting read on the problem - http://stackoverflow.com/questions/2940367/what-is-more-efficient-using-pow-to-square-or-just-multiply-it-with-itself

Vijay: please leave those multiplications as they are :-)


- Rafal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113019/#review45314
-----------------------------------------------------------


On Oct. 9, 2013, 12:06 a.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113019/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2013, 12:06 a.m.)
> 
> 
> Review request for KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> As such there are no major changes made in Moon Position algorithm in Meeus 1998 from Meeus 1991 but few constants are modified which increases accuracy by few arc-seconds. 
> 
> Previously Tools->Calculator->Time Calculators->Almanac always produced phase unknown which is fixed by calling findPosition() and findPhase() before calling illum(). 
> 
> 
> Diffs
> -----
> 
>   kstars/skyobjects/ksmoon.cpp ac7e4ed 
>   kstars/tools/modcalcdaylength.cpp b11cca2 
> 
> Diff: http://git.reviewboard.kde.org/r/113019/diff/
> 
> 
> Testing
> -------
> 
> Tools->Calculator->Time Calculators->Almanac produces correct phase.
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131207/579cfa51/attachment.html>