[Kstars-devel] Review Request 112898: Setting alt/az from ra/dec for constellation object while loading data and solve bug 325198

[Rafal Kulaga]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112898/#review45317
-----------------------------------------------------------

Ship it!


Ship it and remember to close the corresponding bug.


kstars/skycomponents/constellationnamescomponent.cpp
<http://git.reviewboard.kde.org/r/112898/#comment32365>

    Don't name it m_* as it is not a member of the ConstellationNamesComponent class :-) Apart from that, I think that we can get away without storing this pointer, just use KStarsData::Instance() directly.


- Rafal Kulaga


On Oct. 17, 2013, 10:17 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112898/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2013, 10:17 p.m.)
> 
> 
> Review request for KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.
> 
> 
> Bugs: 266774 and 325198
>     http://bugs.kde.org/show_bug.cgi?id=266774
>     http://bugs.kde.org/show_bug.cgi?id=325198
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> While loading data from file, only ra/dec for constellation object are set which leads in error when alt/az of constellation objects are used without call to SkyPoint:EquatorialToHorizontal() (attached bug are examples). To avoid such scenario alt/az of constellation object are set while loading it to ConstellationNamesComponent.
> 
> 
> Diffs
> -----
> 
>   kstars/skycomponents/constellationnamescomponent.cpp 0b43633 
> 
> Diff: http://git.reviewboard.kde.org/r/112898/diff/
> 
> 
> Testing
> -------
> 
> Tested
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131207/dc153bbb/attachment-0001.html>