[Kstars-devel] Review Request 112720: Removing repeated check for height and width of image under getDSSURL functions and making observation list table resizable to user

[Rafal Kulaga]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112720/#review45311
-----------------------------------------------------------

Ship it!


Ship it, but please first:
- remove unused variables dms ra(0.0), dec(0.0) from QString KSUtils::getDSSURL( const SkyPoint * const p );
- remove empty line after return in QString KSUtils::getDSSURL( const dms &ra, const dms &dec, float width, float height, const QString & type).

Apart from that, everything looks fine.

- Rafal Kulaga


On Sept. 14, 2013, 11:20 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112720/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2013, 11:20 p.m.)
> 
> 
> Review request for KStars, Akarsh Simha and Rishab Arora.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Height and width of image are being checked twice for same validity under getDSSURL function so first check is removed. 
> Making Wish list and Session plan table column under Observation list resizable by user for better usability.    
> 
> 
> Diffs
> -----
> 
>   kstars/ksutils.cpp d517deb 
>   kstars/tools/observinglist.cpp 7eb5ab5 
> 
> Diff: http://git.reviewboard.kde.org/r/112720/diff/
> 
> 
> Testing
> -------
> 
> Runs correctly 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131207/74497d00/attachment.html>