[Kstars-devel] Review Request 111032: Fix empty names in the find dialog.

[Albert Astals Cid]

> On June 16, 2013, 5:02 a.m., Henry de Valence wrote:
> > Ship It!

Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111032/#review34408
-----------------------------------------------------------


On June 15, 2013, 3:06 a.m., Aneesh Dogra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111032/
> -----------------------------------------------------------
> 
> (Updated June 15, 2013, 3:06 a.m.)
> 
> 
> Review request for KStars.
> 
> 
> Description
> -------
> 
> Edit the setNames method of StarObject to expand greek characters in longname and use the longname() method to get the name of the star in starcomponent.cpp.
> 
> This fixes the empty names in the find dialog, gives out better names for entries and uses less code.
> 
> 
> Diffs
> -----
> 
>   kstars/skycomponents/starcomponent.cpp a44e37a 
>   kstars/skyobjects/starobject.cpp 8976341 
> 
> Diff: http://git.reviewboard.kde.org/r/111032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aneesh Dogra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130815/a26e2075/attachment.html>