[Kstars-devel] Review Request 104403: All features related to supernovae implemented.

[Samikshan Bairagya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104403/
-----------------------------------------------------------

(Updated April 23, 2013, 1:21 a.m.)


Status
------

This change has been marked as submitted.


Review request for KStars, Akarsh Simha and Rafal Kulaga.


Description
-------

Request to review local 'sok' branch before merging it to 'master'.
Features added: 
1. Notification for supernovae updates.
2. Page for supernovae options in KStars options.
3. Supernovae in OpenGL backend.

Review required on these points:
1. Check if the supernova icon is visible on the view toolbar and on KStars options window.
2. Check if bug #293183 is being generated.
3. Rendering of supernovae in OpenGL backend. Are the plus signs distorted?


Diffs
-----

  kstars/CMakeLists.txt dd733ee 
  kstars/data/scripts/supernova_updates_parser.py f3ec1bd 
  kstars/icons/hi22-action-kstars_supernovae.png PRE-CREATION 
  kstars/icons/hi32-action-kstars_supernovae.png PRE-CREATION 
  kstars/icons/hi48-action-kstars_supernovae.png PRE-CREATION 
  kstars/icons/hi64-action-kstars_supernovae.png PRE-CREATION 
  kstars/kstars.h 8ac71f5 
  kstars/kstars.cpp e833720 
  kstars/kstars.kcfg 395bd94 
  kstars/kstarsactions.cpp ba7018a 
  kstars/kstarsdcop.cpp d1887d6 
  kstars/kstarsui-indi.rc c9ba3c1 
  kstars/kstarsui-win.rc 6e42c6c 
  kstars/kstarsui.rc 9ee4b0e 
  kstars/options/opssupernovae.h PRE-CREATION 
  kstars/options/opssupernovae.cpp PRE-CREATION 
  kstars/options/opssupernovae.ui PRE-CREATION 
  kstars/skycomponents/notifyupdatesui.h PRE-CREATION 
  kstars/skycomponents/notifyupdatesui.cpp PRE-CREATION 
  kstars/skycomponents/notifyupdatesui.ui PRE-CREATION 
  kstars/skycomponents/skymapcomposite.cpp 1b8beb6 
  kstars/skycomponents/supernovaecomponent.h ab824c6 
  kstars/skycomponents/supernovaecomponent.cpp 5c3c8bb 
  kstars/skyglpainter.cpp 2a74af9 

Diff: http://git.reviewboard.kde.org/r/104403/diff/


Testing
-------

1. Tested page for supernova options for bug #293183, for all projections.
2. No bugs found for supernova updates notification.


Screenshots
-----------

Notification of supernova updates.
  http://git.reviewboard.kde.org/r/104403/s/491/
Supernova options
  http://git.reviewboard.kde.org/r/104403/s/492/
Toggle supernovae from view toolbar
  http://git.reviewboard.kde.org/r/104403/s/493/


Thanks,

Samikshan Bairagya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130423/78b828bc/attachment-0001.html>