[Kstars-devel] Review Request: Include many methods to set the RA/Dec of a SkyPoint to increase programming clarity

[Akarsh Simha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106658/
-----------------------------------------------------------

(Updated Sept. 30, 2012, 8:08 a.m.)


Review request for KStars, Rafal Kulaga and Aleksey Khudyakov.


Changes
-------

Fixed comments to reflect reality.


Description
-------

To reduce confusion and increase clarity, define three new coordinate-setting methods for SkyPoint, and modify the existing one so that it has a mandatory epoch argument.

Earlier, there was only one method called set(RA, Dec) that would set both (RA0, Dec0) and (RA, Dec). This must be handled with care. Instead, the new methods set only the valid data, and invalidate the other data. This might not be very useful in itself, but the clarity it adds is useful. Just a plain "set" needs an additional epoch argument, and uses deprecess() to set the RA0 and Dec0 correctly. The explicitness in using setCurrent, setJ2000 or setBoth is advantageous.


Diffs (updated)
-----

  kstars/dialogs/focusdialog.cpp c506c90 
  kstars/projections/equirectangularprojector.cpp 37475a1 
  kstars/projections/projector.cpp 18c6489 
  kstars/skycomponents/customcatalogcomponent.cpp 83159d4 
  kstars/skymap.cpp e0c3194 
  kstars/skyobjects/skypoint.h c3549a3 
  kstars/skyobjects/skypoint.cpp 646b949 
  kstars/tools/obslistwizard.cpp e02a490 

Diff: http://git.reviewboard.kde.org/r/106658/diff/


Testing
-------

A basic run of KStars rendered the SkyMap seemingly fine. The use of slotDSS() gave correct results for September 2012.


Thanks,

Akarsh Simha

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20120930/083d5c2e/attachment.html>