[Kstars-devel] Review Request: Fixed bug 296627: drawing observing list markers in OpenGL

[Rishab Arora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104392/
-----------------------------------------------------------

Review request for KStars.


Description
-------

Cause: In SkyGLPainter::drawObservingList, for each point there were 6 coordinates added but 'i' was incremented one. Changing ++i to i+=6 fixes that but the texture is replaced by a blue box at high zoom.
Solution: I used drawTexturedRectangle which is already being used to draw planets to draw the observation markers. Was the old method implemented with a different design in mind?


This addresses bug 296627.
    http://bugs.kde.org/show_bug.cgi?id=296627


Diffs
-----

  kstars/skyglpainter.cpp 2a74af9 

Diff: http://git.reviewboard.kde.org/r/104392/diff/


Testing
-------

Repeated steps in bug description.  No problems found.


Screenshots
-----------

Corrected markers
  http://git.reviewboard.kde.org/r/104392/s/488/


Thanks,

Rishab Arora

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20120323/538cb38a/attachment.html>