[Kstars-devel] Review Request: Fix dissapearing Milky Way at high zoomlevel on QPainter

[Rishab Arora]

> On March 18, 2012, 12:11 a.m., Rafal Kulaga wrote:
> > This patch indeed fixes the problem, but I wonder if the clipping here is needed at all? It seems that we can get rid of it.

I think so too! And that is what I wanted to confirm if we get any advantage at all from ignoring points manually instead of painters perform the clipping themselves. Attached p3.patch which works on both backends on the same principle.


- Rishab


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104320/#review11512
-----------------------------------------------------------


On March 17, 2012, 11:12 p.m., Rishab Arora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104320/
> -----------------------------------------------------------
> 
> (Updated March 17, 2012, 11:12 p.m.)
> 
> 
> Review request for KStars, Rafal Kulaga and Akarsh Simha.
> 
> 
> Description
> -------
> 
> Fixes bug https://bugs.kde.org/show_bug.cgi?id=266929 for QPainter backend only.
> At high zoomlevel, the points leave the FOV and are ignored completely, whereas their fill should not be.
> Used clipping in QPainter to fix bug.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=266929.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=266929
> 
> 
> Diffs
> -----
> 
>   kstars/projections/projector.h 966d002 
>   kstars/projections/projector.cpp e8c1aff 
>   kstars/skyqpainter.cpp 43f06e8 
> 
> Diff: http://git.reviewboard.kde.org/r/104320/diff/
> 
> 
> Testing
> -------
> 
> Tested at various zoomlevels and resolutions. No issues found.
> 
> 
> Thanks,
> 
> Rishab Arora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20120318/0ba5fa19/attachment.html>