[Kstars-devel] Review Request: Implemented GUI that would notify newly discovered supernovae.

Rafal Kulaga rl.kulaga at gmail.com
Sat Mar 10 22:16:57 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104214/#review11275
-----------------------------------------------------------

Ship it!


Looks great! You might want to the change class name to indicate that it's supernovae-specific.

- Rafal Kulaga


On March 10, 2012, 10:50 a.m., Samikshan Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104214/
> -----------------------------------------------------------
> 
> (Updated March 10, 2012, 10:50 a.m.)
> 
> 
> Review request for KStars, Rafal Kulaga and Akarsh Simha.
> 
> 
> Description
> -------
> 
> Added three files:
> 1. kstars/skycomponents/notifyupdatesui.ui
> 2. kstars/skycomponents/notifyupdatesui.h
> 3. kstars/skycomponents/notifyupdatesui.cpp
> 
> Notification is done as a tree(QTreeWidget) inside a QDialog. Clicking on a QTreeWidgetItem and then clicking on the "Slew map to object" button would center the skyobject on the skymap. Information showed for newly discovered supernovae are:
> 1. Host Galaxy
> 2. Date of discovery
> 3. Magnitude
> 4. Type
> 5. Position (RA, Dec)
> 
> 
> Diffs
> -----
> 
>   kstars/skycomponents/notifyupdatesui.h PRE-CREATION 
>   kstars/CMakeLists.txt PRE-CREATION 
>   kstars/skycomponents/notifyupdatesui.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104214/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Notification Dialog
>   http://git.reviewboard.kde.org/r/104214/s/459/
> 
> 
> Thanks,
> 
> Samikshan Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20120310/9a25c23f/attachment.html>


More information about the Kstars-devel mailing list