[Kstars-devel] Review Request: Display faint stars in OpenGL backend

[Akarsh Simha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104387/#review15368
-----------------------------------------------------------

Ship it!


Ship It!

- Akarsh Simha


On March 23, 2012, 3:21 p.m., Rishab Arora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104387/
> -----------------------------------------------------------
> 
> (Updated March 23, 2012, 3:21 p.m.)
> 
> 
> Review request for KStars, Rafal Kulaga and Akarsh Simha.
> 
> 
> Description
> -------
> 
> Removed condition in SkyGLPainter::addItem to ignore points with width less than 1.5
> Reason:
> SkyPainter::starWidth already contains a condition according to which the stars that are too faint are allotted a width of 1.0
> 
> 
> This addresses bug 266928.
>     http://bugs.kde.org/show_bug.cgi?id=266928
> 
> 
> Diffs
> -----
> 
>   kstars/skyglpainter.cpp 2a74af9 
> 
> Diff: http://git.reviewboard.kde.org/r/104387/diff/
> 
> 
> Testing
> -------
> 
> 1. View any region with QPainter Backend.
> 2. Switch backend to OpenGL and compare.
> 
> Matched output with QPainter backend for all projections. No missing stars anymore at any zoom level.
> 
> 
> Thanks,
> 
> Rishab Arora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20120704/e7ccecf2/attachment.html>