[Kstars-devel] Review Request: Daylight Savings Time correction: time set before loading the Rulebook

[Marta Rybczyńska]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102530/
-----------------------------------------------------------

(Updated Sept. 4, 2011, 7:17 p.m.)


Review request for KStars.


Changes
-------

Correct patch attached.


Summary
-------

This patch fixes another path that leads to incorrect DST settings at startup.

This patch moves location and time setup after complete initialization (including DST Rulebook). Otherwise, time setup does not find the right DST value.

Problem description: During standard runtime, Rulebook is not yet loaded when the first setLocationFromOptions is called. It means that at the moment of the DST set-up, there are no rules available. This is masked by the usage of QMap which returns the default value if an element doesn't exist in the map. That is exactly what happens. All other location settings are unaffected.


This addresses bug 209647.
    http://bugs.kde.org/show_bug.cgi?id=209647


Diffs (updated)
-----

  kstars/kstars.cpp ed757a3 

Diff: http://git.reviewboard.kde.org/r/102530/diff


Testing
-------

During multiple consecutive runs works OK.


Thanks,

Marta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20110904/8a174cfe/attachment.html>