[Kstars-devel] Re: Review Request: Add SVG format support for sky image export function.

[Aleksey Khudyakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101268/#review3030
-----------------------------------------------------------


Looks fine. Although return from middle of function do not improve readability.
Probably it's better to structure code like that:

if( save_to_SVG ) {
   // Save to SVG
} else { 
   // Save to raster format
   
}


Please add following line to commit messageю I'll close bug in meantime

CCBUG: 109042 

- Aleksey


On May 1, 2011, 8:28 p.m., Rafal Kulaga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101268/
> -----------------------------------------------------------
> 
> (Updated May 1, 2011, 8:28 p.m.)
> 
> 
> Review request for KStars.
> 
> 
> Summary
> -------
> 
> Class QSvgGenerator is used as a QPaintDevice for SkyMapDrawAbstract::exportSkyImage() method.
> 
> Overlays, names etc. are saved as vector graphics; sky images are saved as raster graphics (<image> element).
> 
> 
> Diffs
> -----
> 
>   kstars/kstarsactions.cpp d0f4094 
>   kstars/kstarsdcop.cpp a70d732 
> 
> Diff: http://git.reviewboard.kde.org/r/101268/diff
> 
> 
> Testing
> -------
> 
> Done basic testing, no problems detected.
> 
> 
> Thanks,
> 
> Rafal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kstars-devel/attachments/20110501/39836655/attachment.htm