[Kstars-devel] Re: Review Request: This patch fixes the magnitude parameter of observable comets by using a different formula altogether.

[Samikshan Bairagya]

> On June 17, 2011, 5:37 a.m., Akarsh Simha wrote:
> > kstars/skycomponents/cometscomponent.cpp, line 254
> > <http://git.reviewboard.kde.org/r/101650/diff/1/?file=24595#file24595line254>
> >
> >     Is this change intentional? Also, although it's not your code, you may want to try cutting down on that GET string, it has a lot of unnecessary parameters I guess...

Yes, this change was intentional. Intended to have K1,K2 parameters in the comets.dat file as well. 
Okay, I'll try cutting down.


- Samikshan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101650/#review3945
-----------------------------------------------------------


On June 17, 2011, 5:15 a.m., Samikshan Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101650/
> -----------------------------------------------------------
> 
> (Updated June 17, 2011, 5:15 a.m.)
> 
> 
> Review request for KStars.
> 
> 
> Summary
> -------
> 
> The patch is dirty now. Will look into it. This patch fixes the magnitude parameter of observable comets by using a different formula altogether.
> T-Mag = M1 + 5*log10(rearth) + k1*log10(rsun). Comets for which data are not available will have abnormal magnitudes of 99.
> For formula refer: http://ssd.jpl.nasa.gov/horizons.cgi
> 
> Changed CometsComponent::updateDataFile() to store the k1,k2 parameters as well in the comets.dat file
> Changed CometsComponent::loadData() to load M1, M2, K1, K2 parameters as well. Also if M1, M2, K1, K2 data are not available set abnormal values as default.
> Changed KSComet.h and KSComet.cpp to accept M1, M2, K1, K2 parameters as well. Also modified KSComet::findMagnitude() to use the above formula.
> Changed setMag() function in SkyObject.h so that for any magnitudes >=30 abnormally high value(99) is set. 
> 
> 
> Diffs
> -----
> 
>   kstars/dialogs/detaildialog.cpp 3d669ef 
>   kstars/skycomponents/cometscomponent.cpp 4a2851b 
>   kstars/skyobjects/kscomet.h 5a858ee 
>   kstars/skyobjects/kscomet.cpp e665c70 
>   kstars/skyobjects/skyobject.h 6f6a061 
> 
> Diff: http://git.reviewboard.kde.org/r/101650/diff
> 
> 
> Testing
> -------
> 
> Tested for various comets.
> 
> 
> Thanks,
> 
> Samikshan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kstars-devel/attachments/20110617/0286c47f/attachment.htm