[Kstars-devel] Re: Review Request: Adding recent supernovae to KStars

[Akarsh Simha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102091/#review5116
-----------------------------------------------------------

Ship it!


Looks great! Congratulations. I could just find some minor things to bother you with.

Also, you don't seem to have added the python script.


kstars/kstars.h
<http://git.reviewboard.kde.org/r/102091/#comment4598>

    Remove this unnecessary line. Do you know what these are? Else, ask me to explain.



kstars/skycomponents/supernovaecomponent.h
<http://git.reviewboard.kde.org/r/102091/#comment4599>

    Usually, you'd put that as a @note. @short is the short description of the method.



kstars/skycomponents/supernovaecomponent.cpp
<http://git.reviewboard.kde.org/r/102091/#comment4601>

    Where is this file stored? "appdata" sounds weird to me... But I really do not know. It's likely you're right.



kstars/skycomponents/supernovaecomponent.cpp
<http://git.reviewboard.kde.org/r/102091/#comment4600>

    Where is this file stored? "appdata" seems weird to me, although I really do not know.



kstars/skyobjects/supernova.h
<http://git.reviewboard.kde.org/r/102091/#comment4602>

    I recommend making those const dms &ra instead. Just a bit more efficient and clean.


- Akarsh


On July 26, 2011, 7:12 a.m., Samikshan Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102091/
> -----------------------------------------------------------
> 
> (Updated July 26, 2011, 7:12 a.m.)
> 
> 
> Review request for KStars, Victor Carbune, Rafal Kulaga, and Akarsh Simha.
> 
> 
> Summary
> -------
> 
> This diff adds recently observed supernovae to KStars. Data is extracted from http://www.cbat.eps.harvard.edu/lists/RecentSupernovae.html using a python script.
> Data is stored in a CSV format. The supernovae are drawn on the skymap as small orange plus signs. Also Supernovae maybe found out by name from the Find 
> Object dialog.box. I have yet to write the SkyGLPainter::drawSupernova() method.
> 
> 
> Diffs
> -----
> 
>   kstars/CMakeLists.txt 0c335b6 
>   kstars/colorscheme.cpp 9d669a1 
>   kstars/data/chart.colors 5515c1b 
>   kstars/data/classic.colors 31e6706 
>   kstars/data/moonless-night.colors c1d3b06 
>   kstars/data/night.colors a31f69e 
>   kstars/kstars.h 6516f9e 
>   kstars/kstars.kcfg 6d088d7 
>   kstars/kstarsactions.cpp e917cac 
>   kstars/kstarsdata.cpp 2303c5f 
>   kstars/kstarsinit.cpp 7f4471e 
>   kstars/skycomponents/skymapcomposite.h adf496d 
>   kstars/skycomponents/skymapcomposite.cpp 82fef8a 
>   kstars/skycomponents/supernovaecomponent.h PRE-CREATION 
>   kstars/skycomponents/supernovaecomponent.cpp PRE-CREATION 
>   kstars/skyglpainter.h 2aa8d87 
>   kstars/skyglpainter.cpp 655d2c7 
>   kstars/skyobjects/skyobject.h 3a6122f 
>   kstars/skyobjects/supernova.h PRE-CREATION 
>   kstars/skyobjects/supernova.cpp PRE-CREATION 
>   kstars/skypainter.h 1340568 
>   kstars/skyqpainter.h df7cc9b 
>   kstars/skyqpainter.cpp 87719b2 
> 
> Diff: http://git.reviewboard.kde.org/r/102091/diff
> 
> 
> Testing
> -------
> 
> Testing has been done with all colour schemes and in QPainter backend.
> 
> 
> Thanks,
> 
> Samikshan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kstars-devel/attachments/20110726/56a7f65e/attachment-0001.htm