[Kstars-devel] Review Request: Fix memory leak in LineListIndex class [found by tsdgeos]

Rafal Kulaga rl.kulaga at gmail.com
Tue Jul 12 20:52:26 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101935/
-----------------------------------------------------------

Review request for KStars, Victor Carbune and Akarsh Simha.


Summary
-------

The uploaded diff fixes memory leak in LineListIndex, which was found by tsdgeos. Although it's not very serious (LineListIndex subclasses are rarely deleted during KStars execution, e.g. when user enables and disables Star Catalogs tickbox in KStars Options window -> Catalogs page in which case ConstellationLines class instance is destroyed, which is a subclass of LineListIndex) it should be removed.


Diffs
-----

  kstars/skycomponents/linelistindex.h f76ea50 
  kstars/skycomponents/linelistindex.cpp ac4166f 

Diff: http://git.reviewboard.kde.org/r/101935/diff


Testing
-------

Tested, works fine.


Thanks,

Rafal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kstars-devel/attachments/20110712/40585c98/attachment.htm 


More information about the Kstars-devel mailing list