[Kstars-devel] Review Request: Legend feature (currently used only for exported images)

[Rafal Kulaga]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101912/
-----------------------------------------------------------

Review request for KStars, Victor Carbune and Akarsh Simha.


Summary
-------

Attached diff adds the option to include legends in exported sky images. Both vertical and horizontal orientations are supported; there are two types of legend: full-blown (symbol descriptions, star magnitudes and scale) and scale-only. Some changes will inevitably be made to this code in a few days - please note that there are some hard-coded values in legend.cpp which will be gone after integration with the functionality I am developing now (FOV representation exporting).

Any comments are welcome, be they look&feel or code-related.


Diffs
-----

  kstars/CMakeLists.txt 0c335b6 
  kstars/dialogs/exportimagedialog.h PRE-CREATION 
  kstars/dialogs/exportimagedialog.cpp PRE-CREATION 
  kstars/dialogs/exportimagedialog.ui PRE-CREATION 
  kstars/kstarsactions.cpp e917cac 
  kstars/kstarsdcop.cpp 42dcb0f 
  kstars/legend.h PRE-CREATION 
  kstars/legend.cpp PRE-CREATION 
  kstars/skymap.h e7a7f56 
  kstars/skymapdrawabstract.h c94a745 
  kstars/skymapdrawabstract.cpp cf44fc5 
  kstars/skypainter.h 1340568 
  kstars/skyqpainter.h df7cc9b 
  kstars/skyqpainter.cpp 87719b2 

Diff: http://git.reviewboard.kde.org/r/101912/diff


Testing
-------

Done some testing, everything worked (and looked) fine for me.


Thanks,

Rafal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kstars-devel/attachments/20110710/447cc62c/attachment.htm