[Kstars-devel] Review Request: Fix FindINDI CMake module

[Jasem Mutlaq]

> On Aug. 23, 2011, 6:43 p.m., Jasem Mutlaq wrote:
> > The FindINDI.cmake module in KStars is _identical_ to the one used by upstream INDI and KStars find libindi using it on my Kubuntu 11.04 machine. Therefore, this patch is not required.
> 
> Rohan Garg wrote:
>     Hi
>     Starting from libindi 0.8 upstream changed how libindi is detected, and most of the indi drivers now use this particular updated Module, i've just copied over the indi driver findCMake to the KStars repo and generated the diff

Hi Rohan,

You made the diff against which KStars exactly?


- Jasem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102119/#review5950
-----------------------------------------------------------


On July 28, 2011, 4:36 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102119/
> -----------------------------------------------------------
> 
> (Updated July 28, 2011, 4:36 p.m.)
> 
> 
> Review request for KStars.
> 
> 
> Summary
> -------
> 
> The current FindINDI.cmake module feels more of a hack than a proper solution, it also does not detect libindi 0.8 on ubuntu.
> This patch is derived from upstream indi drivers which i feel have a better implementation of FindINDI.cmake
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindINDI.cmake 40d77a4 
> 
> Diff: http://git.reviewboard.kde.org/r/102119/diff
> 
> 
> Testing
> -------
> 
> KStars now correctly detects libindi 0.8 on my Ubuntu machine
> 
> 
> Thanks,
> 
> Rohan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20110823/a223ec91/attachment.html>