[Kstars-devel] Moon's magnitude calculated too lazily.

[Akarsh Simha]

Hi Alexey,

> I've noticed that magnitude of Moon calculated too lazily. It could be easily 
> spotted with my patch for popup menu. Right-click on Moon first time after 
> launching kstars and you will see magnitude 0.0m. It you go to details dialog 
> or click second time normal magnitude will be displayed.

Could you check if this is fixed for you now? It seems to work for me.
In revision 942491, I got KSPlanetBase::findPosition() to call
KSMoon::findPhase() whenever the position changes, so this should
theoretically be fine now.

> Also I've noticed that findMagnitude(..) method declared in KSMoon class but 
> never defined. Actual calculations are performed in KSBasePlanet class. I 
> suppose this declaration should be removed.

Done. Thanks. [Rev. 942503]

Regards
Akarsh