[Kstars-devel] [PATCH] Support of non-western constellations

[Jérôme SONRIER]

Le mercredi 15 octobre 2008, Akarsh Simha a écrit :
> > > Notes :
> > > Lots of constellations are missing because some stars don't have
> > > a Bayer designation and I can not use them in clines.dat (e.g.
> > > HD224926, HD2411,...). Is there a way to use this stars in
> > > clines.dat ?
> >
> > Why not converting everything to use the HD numbers rather than
> > Bayer designation? I guess no constellation uses a star which does
> > not have a HD number.
>
> This might be a good idea. I've added a HD field to every StarObject
> that could be retrieved using StarObject::getHDIndex(). We could base
> the "matching" for stars on that rather than Bayer
> designation. There's a StarComponent::findByHDIndex() for this.
> Unlike earlier, this will require no change in the catalogs :).
> Besides, the startup might become faster because we are doing number
> matching rather than string matching.
>
> I still haven't looked at the patch and will do so this weekend.
>
> Regards
> Akarsh

I just made a test and it's work fine using 
StarComponent::findByHDIndex(). I will convert clines.dat to use HD 
numbers instead of Bayer designation and remake my patch taking into 
account others comments of Médéric.


-- 
Jérôme SONRIER