[Kstars-devel] KDE/kdeedu/kstars/kstars

Akarsh Simha akarshsimha at gmail.com
Sat Dec 20 01:58:42 CET 2008


SVN commit 899149 by asimha:

+ In future, constellation names for localization must be pulled
  directly out of starnames.dat. Add a TODO to remind us about this.

+ Fix potential memory leak

CCMAIL: kstars-devel at kde.org



 M  +1 -0      Messages.sh  
 M  +4 -0      skycomponents/skymapcomposite.cpp  


--- trunk/KDE/kdeedu/kstars/kstars/Messages.sh #899148:899149
@@ -37,6 +37,7 @@
 sort --unique info_url.tmp >> kstars_i18n.cpp
 
 # star names : some might be different in other languages, or they might have to be adapted to non-Latin alphabets
+# TODO: Move this thing to starnames.dat
 cat data/stars.dat | gawk 'BEGIN { FS=", "; } ($1!~/\#/ && NF==3) { printf( "i18nc(\"star name\", \"%s\");\n", $3); }' >> kstars_i18n.cpp;
 
 # extract deep-sky object names (sorry, I don't know perl-fu ;( ...using AWK )
--- trunk/KDE/kdeedu/kstars/kstars/skycomponents/skymapcomposite.cpp #899148:899149
@@ -492,11 +492,15 @@
 }
 
 void SkyMapComposite::reloadCLines( KStarsData *data ) {
+    if( m_CLines ) 
+        delete m_CLines;
     m_CLines = new ConstellationLines( this );
     m_CLines->init( data );
 }
 
 void SkyMapComposite::reloadCNames( KStarsData *data ) {
+    if( m_CNames )
+        delete m_CNames;
     m_CNames = new ConstellationNamesComponent( this );
     m_CNames->init( data );
 }


More information about the Kstars-devel mailing list