[Kstars-devel] [PATCH] Prettier (?) stars

[Médéric Boquien]

Hi,

Apparently i always let a bug slip in a patch, i am really sorry. Here is an 
updated patch. I am not sure it is quite correct, i have hardcoded the value 
of the maximum colour intensity, is it accessible somewhere? This is very bug 
prone if we change the max value one day.
I have noticed a nasty bug when printing (both in trunk and 4.1). Set the 
colour scheme to star chart, print. The colours of the stars (and only the 
stars, not the sky) is back to the scheme that was used at startup.

Regards,

Médéric

Le Thursday 28 August 2008 21:08:11 Jason Harris, vous avez écrit :
> Hi Médéric,
>
> The patch looks good, except for one bug: the saturation parameter in
> the Colors page of the Config window is now inverted: *lower*
> saturation values lead to *more* saturated star colors.
>
> Jason
>
> On Aug 27, 2008, at 10:43 PM, Médéric Boquien wrote:
> > Hello,
> >
> > I have polished the patch to make it a bit cleaner and faster. I
> > think it is
> > ready for inclusion if you think it looks better than currently.
> > I have timed the speed difference with 4.1 branch. It is hard to
> > compare
> > directly as the number of stars is not the same but it seems to take
> > about the
> > same time. For information, on a core 2 Q9450 with a nvidia graphics
> > card
> > running the binary driver, with the extended catalogue (setting the
> > number of
> > stars on screen to the minimum), fairly zoomed out, it takes ~100ms/
> > image. It
> > looks a bit long, especially if we want to increase the number of
> > stars
> > displayed.
> >
> > Regards,
> >
> > Médéric
> >
> > Le Thursday 21 August 2008 02:02:21 Jason Harris, vous avez écrit :
> >> Thanks Mederic.
> >>
> >> BTW, note that this shouldn't be any slower than the original star
> >> images, despite the fact that drawing them is more complicated.  Star
> >> images are cached and blitted to the screen.  So constructing the
> >> star
> >> image cache will be a bit slower, but that is a very rare operation.
> >>
> >> Jason
> >>
> >> On Wed, Aug 20, 2008 at 10:32 PM, Médéric Boquien
> >>
> >> <mboquien at free.fr> wrote:
> >>> Hello,
> >>>
> >>> I have made a patch which modifies the aspect of stars in the
> >>> "Classic"
> >>> and "Moonless night" colour schemes. In summary, instead of
> >>> drawing a
> >>> coloured annulus around the central white circle, i use the change
> >>> the
> >>> saturation and the transparency in function of the radius, so it
> >>> looks a
> >>> bit more smooth and blends with the background. The attached patch
> >>> is
> >>> included if you want to play and if you find a better transfer
> >>> function
> >>> for the saturation and the transparency channels. Note, it is not
> >>> 100%
> >>> clean, and i do not expect it to be committed yet. For the most
> >>> impatient, i have also included a screenshot. What do you think of
> >>> the
> >>> new stars. Are they better? Worse? How could they be improved?
> >>>
> >>> Thanks,
> >>>
> >>> Médéric
> >>>
> >>> _______________________________________________
> >>> Kstars-devel mailing list
> >>> Kstars-devel at kde.org
> >>> https://mail.kde.org/mailman/listinfo/kstars-devel
> >
> > <colors_final.patch>
>
> _______________________________________________
> Kstars-devel mailing list
> Kstars-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kstars-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: colors_final2.patch
Type: text/x-patch
Size: 2762 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kstars-devel/attachments/20080828/315682d9/attachment.patch