[Kstars-devel] KDE/kdeedu/kstars/kstars/skycomponents

[Thomas Kabelmann]

Hi Jason,

as the destructor is declared virtual, it automatically calls the destructor 
of it's parent class. It's a little bit confusing syntax anyway :-)

Cheers,
Thomas

Am Samstag, 17. September 2005 04:48 schrieb Jason Harris:
> SVN commit 461267 by harris:
>
> Added EclipticComponent.  Modified destructor of
> SolarSystemComposite (can you review this change, Thomas?)
>
> CCMAIL: kstars-devel at kde.org
>
>
>  M  +1 -1      Makefile.am
>  A             eclipticcomponent.cpp   [License: GPL (v2+)]
>  A             eclipticcomponent.h   [License: GPL (v2+)]
>  M  +2 -1      equatorcomponent.cpp
>  M  +3 -0      solarsystemcomposite.cpp
>
>
> --- trunk/KDE/kdeedu/kstars/kstars/skycomponents/Makefile.am #461266:461267
> @@ -5,7 +5,7 @@
>  			constellationboundarycomponent.cpp \
>  			coordinategridcomposite.cpp coordinategridcomponent.cpp \
>  			customcatalogscomponent.cpp deepskycomponent.cpp \
> -			equatorcomponent.cpp horizoncomponent.cpp \
> +			eclipticcomponent.cpp equatorcomponent.cpp horizoncomponent.cpp \
>  			jupitermoonscomponent.cpp milkywaycomponent.cpp \
>  			mooncomponent.cpp skycomponent.cpp skycomposite.cpp \
>  			skymapcomposite.cpp solarsystemcomposite.cpp \
> --- trunk/KDE/kdeedu/kstars/kstars/skycomponents/equatorcomponent.cpp
> #461266:461267 @@ -35,6 +35,7 @@
>
>  EquatorComponent::~EquatorComponent()
>  {
> +  while ( ! Equator.isEmpty() ) delete Equator.takeFirst();
>  }
>
>  // was KStarsData::initGuides(KSNumbers *num)
> @@ -56,7 +57,7 @@
>  void EquatorComponent::update(KStarsData *data, KSNumbers *num, bool
> needNewCoords) {
>  	if ( Options::showEquator() ) {
> -		for ( SkyPoint *p = Equator.first(); p; p = Equator.next() ) {
> +	  foreach ( SkyPoint *p, Equator ) {
>  			p->EquatorialToHorizontal( LST, data->geo()->lat() );
>  		}
>  	}
> --- trunk/KDE/kdeedu/kstars/kstars/skycomponents/solarsystemcomposite.cpp
> #461266:461267 @@ -35,6 +35,9 @@
>
>  SolarSystemComposite::~SolarSystemComposite::()
>  {
> +  //JH: is this necessary to call, or is it done automatically?
> +  SkyComposite::~SkyComposite();
> +
>  	delete Earth;
>  	delete Sun;
>  	delete Venus;
> _______________________________________________
> Kstars-devel mailing list
> Kstars-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kstars-devel