[Kstars-devel] kdeedu/kstars/kstars

[Jason Harris]

CVS commit by harris: 

Fixed a bug that I should have caught long ago...

When computing the rise/set times for an object, we use a function 
SkyObject::recomputeCoords() to temporarily reposition the object.  This 
function restored the original coordinates of the object with "set( 
originalRA, originalDec )".   

However, the "set()" function sets the *J2000* coordinates, whereas 
originalRA and originalDec were the precessed coords for the present 
epoch!  So, any time rise/set times were computed, the J2000 coordinates 
were reset to a wrong value!

I noticed this when trying to retrieve images from the Digitized Sky 
Survey; the returned images were slightly off-center. 

The fix was to use "setRA( originalRA )" and "setDec( originalDec )" 
instead. 

CCMAIL: kstars-devel at kde.org


  M +2 -1      skyobject.cpp   1.51


--- kdeedu/kstars/kstars/skyobject.cpp  #1.50:1.51
@@ -294,5 +294,6 @@ SkyPoint SkyObject::recomputeCoords( con
 
         // restore original coords
-        set( original.ra(), original.dec() );
+        setRA( original.ra()->Hours() );
+        setDec( original.dec()->Degrees() );
 
         return sp;