[Kstars-devel] kdeedu/kstars/kstars/indi/fli

Adriaan de Groot groot at kde.org
Sun Apr 24 21:14:28 CEST 2005


On Sunday 24 April 2005 18:28, Jasem Mutlaq wrote:
> On Sunday 24 April 2005 6:33 pm, Gaetano Vocca wrote:
> > I agree with you that this code, as it was, was not portable to other
> > OSes but, simply removing the #define USB_RESET I think you break the
> > behaviour under Linux. So, instead of just deleting the line it is better

Which is why I CC'ed y'all. This kind of unportable stuff keeps creeping into 
kstars -- it's easy for it to happen, you develop on Linux, and the people 
dealing with portability probably don't have any of the equipment to be able 
to care about it actually _working_.

I using something sortof-portable, like libusb, an option here?


> How about we replace #ifdef USB_RESET with #ifdef __linux__? This will make
> the specific code only compiles on Linux and therefore solves the problem?

#ifdef Q_OS_LINUX , then. I think __linux__ doesn't catch all of them.

-- 
These are your friends - Adem
    GPG: FEA2 A3FE Adriaan de Groot


More information about the Kstars-devel mailing list