[Kstars-devel] kdeedu/kstars/kstars/indi/fli

Adriaan de Groot groot at kde.org
Sat Apr 23 23:52:48 CEST 2005


CVS commit by adridg: 

Unconditionally using a OS-specific function (the name
suggests that, at least) seems like a bad idea. This commit
may break functionality, because it might remove the 
linux_usb_reset() call even under linux (I don't know where
USB_RESET might otherwise be defined).

CCMAIL: kstars-devel at kde.org


  M +3 -1      libfli-sys.c   1.4


--- kdeedu/kstars/kstars/indi/fli/libfli-sys.c  #1.3:1.4
@@ -73,5 +73,8 @@ static long unix_fli_list_usb(flidomain_
 static long unix_fli_list_serial(flidomain_t domain, char ***names);
 
+#ifdef USB_RESET
+/* Dodgy OS-specific code. */
 long linux_usb_reset(flidev_t dev);
+#endif
 
 long unix_fli_connect(flidev_t dev, char *name, long domain)
@@ -173,5 +176,4 @@ long unix_fli_disconnect(flidev_t dev)
   CHKDEVICE(dev);
   
-#define USB_RESET
 #ifdef USB_RESET
   if ((DEVICE->domain & 0x00ff) == FLIDOMAIN_USB) {




More information about the Kstars-devel mailing list