[Kstars-devel] kdeedu/kstars/kstars

[Jason Harris]

CVS commit by harris: 

Fixing bug #82294 (moon image reversed in southern hemisphere).  The problem 
was actually not limited to the moon; all object images were flipped left/right 
in the southern hemisphere.

I traced the problem to three mistakes in the code that computes the "position 
angle" of an image; the rotation angle for drawing the image on screen.  These 
three mistakes canceled each other out for northern hemisphere locations, but 
combined to produce the reported bug for southern hemisphere locations.

The position angle code was duplicated in two places: one for planet images, 
and one for deep-sky symbols and images.  Both instances of this code were 
wrong in the same way, so deep-sky object images were similarly flipped in the 
southern hemisphere.  The code is no longer duplicated; all objects now call 
SkyMap::findPA() to get their position angle.

CCMAIL: 82294-done at bugs.kde.org
CCMAIL: kstars-devel at kde.org


  M +2 -2      deepskyobject.cpp   1.6
  M +2 -2      deepskyobject.h   1.6
  M +7 -5      skymap.cpp   1.136
  M +2 -2      skymap.h   1.63
  M +9 -26     skymapdraw.cpp   1.66
  M +5 -0      skyobject.h   1.42