[Kst] Fwd: random KST compiling note

[Zigmund Kermish]

Sure no problem.  I'll keep up to date with git pulls and try recompiling
every now and then to see if any issues pop up.  I usually just recompile
when a new os is released, but can check more frequently if it's helpful.

Ziggy


On Mon, Nov 11, 2013 at 4:34 PM, Nicolas Brisset <nicolas.brisset at free.fr>wrote:

> Hi,
>
> I doubt it is due to one of my recent changes as I haven't touched this
> area. And it looks harmless, so I think we can safely include it and I
> won't even spend time figuring out why it is now needed. It may also depend
> on the Mac OS version...
>
> So thanks to Ziggy! If you could keep up to date with git, it would be
> great as it allows catching this kind of thing early. I develop mainly
> under Linux, sometimes under Windows but never under Mac. I don't know if
> someone else keeps a git version running under Mac.
>
> Nicolas
>
> ----- Mail original -----
> > De: "Barth Netterfield" <barth.netterfield at utoronto.ca>
> > À: kst at kde.org
> > Cc: zkermish at princeton.edu
> > Envoyé: Lundi 11 Novembre 2013 19:58:41
> > Objet: [Kst] Fwd: random KST compiling note
> >
> > Nicolas,
> >
> > Do you think that one of your recent changes may have introduced the
> > problem
> > below on macs?
> >
> > if this looks ok, can you push the change?
> >
> > cbn
> >
> > ----------  Forwarded Message  ----------
> >
> > Subject: random KST compiling note
> > Date: November 11, 2013, 01:46:52 PM
> > From: Zigmund Kermish <zkermish at princeton.edu>
> > To: Barth Netterfield <netterfield at astro.utoronto.ca>
> >
> > Hi Barth,
> >
> > I just re-compiled KST on my mac after a bunch of upgrades, and
> > thought I'd
> > let you know I had to implement the following change for it to
> > compile
> > without error:
> >
> > diff --git a/src/datasources/ascii/kst_atof.cpp
> > b/src/datasources/ascii/kst_atof.cpp
> > index 645d752..e1c735b 100644
> > --- a/src/datasources/ascii/kst_atof.cpp
> > +++ b/src/datasources/ascii/kst_atof.cpp
> > @@ -18,6 +18,7 @@
> >
> >  #include <math.h>
> >  #include <ctype.h>
> > +#include <locale.h>
> >
> >  #include <QLocale>
> >  #include <QTime>
> >
> > ---------------
> >
> > I'm not sure it if the above addition if #include <locale.h> is the
> > correct
> > way to go about this (the errors I was getting were related to
> > LC_NUMERIC
> > being undefined), but it compiled fine after being added.  Let me
> > know if
> > this is the correct fix and/or if I should forward the info to
> > someone else.
> >
> > Ziggy
> > -----------------------------------------
> > --
> > C. Barth Netterfield
> > 416-845-0946
> >
> > _______________________________________________
> > Kst mailing list
> > Kst at kde.org
> > https://mail.kde.org/mailman/listinfo/kst
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kst/attachments/20131112/d232b1c2/attachment.html>