[Kst] Feedback from testing Kst-2.0.x-Qt5-2012.10.17-07.54

[Peter Kümmel]

On 17.10.2012 17:55, Brisset, Nicolas wrote:
>> It parses the file again for rows. And as I understand it the file is always read
>> twice, first for wuilding the index , then when samples are read.
> If _rowIndex contains only the offsets of data lines, it is dependent on the ASCII config, so we'd need to reparse when they change...
> Unless we don't parse until the user clicks "Next" on the first page of the wizard, time at which we need to build the list of variables.
> In fact this is something I wanted to try for a long time: delay the parsing of the whole file to the move from the first to the second page of the wizard.
> I think for the ASCII dialog we only need to read 100 lines, so this should be feasible.

Yes, this makes sense. I also could imagine that it is possible to read the whole file only once into memory, but this 
is anther story ...


> The only problem is if the understands() method used to sort the datasources and select the appropriate one or a given file triggers the complete parsing.
>
>> This feature is so new, that I'm not sure we should enable it by default.
> OK, we can then make it a global setting and leave it up to users to activate it or not. If there are issues they can deactivate it and don't need to wait for a new release. And when we have more experience we will rediscuss it.
> So to conclude on that point and considering your other mail, for 2.0.7 I'd suggest making the ASCII file buffer limitation and threading global settings. In the release notes I'll make users aware of it and call for some feedback, and we can decide whether to keep or not for subsequent versions.
> @Barth: are you OK with that approach?
>
>> Yes, I will upload it to SF.
> Thanks.
>
> EUROCOPTER DEUTSCHLAND GmbH
> Sitz der Gesellschaft / Registered Office: Donauwörth
> Registergericht / Registration Court: Amtsgericht Augsburg HRB 16508
> Vorsitzender des Aufsichtsrates / Chairman of the Supervisory Board: Dr. Lutz Bertling
> Geschäftsführung / Board of Management:
> Dr. Wolfgang Schoder, Vorsitzender / CEO; Friedrich-Wilhelm Hormel; Ralf Barnscheidt
>
>
> CONFIDENTIALITY NOTICE
>
> This communication and the information it contains is intended for the addressee ( s ) named above and for no other persons or organizations.
> It is confidential and may be legally privileged and protected by law. The unauthorized use, copying or disclosure of this communication
> or any part of it is prohibited and may be unlawful.
> If you have received this communication in error, kindly notify us by return e-mail and discard and/or delete the communication.
> Thank you very much.
> It is possible for e-mails to be intercepted or affected by viruses. Whilst we maintain virus checks on our e-mails, we accept no liability for viruses
> or other material which might be introduced with this message.
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst
>