[Kst] branches/work/kst/portto4/kst/src/datasources/ascii

[Brisset, Nicolas]

Hi Peter,

I see you're still improving this ASCII reader :-)

I have been thinking about this topic with the UI and came to the conclusion that I'd do it in the following (decreasing) order of preference:
- Use QSysInfo to detect the platform at run-time and automatically limit the buffer size based on that, the file size and available RAM. That'd mean the user does not need to take care of it, and we can use big buffers for those platforms which support it. If we go this way, we don't need any UI.
- Put the config options relevant to the ASCII reader in the Kst settings. For threads, it seems we use a Qt function to decide whether we should use some or not, so maybe a GUI option is not necessary. Then we'd have only a configurable limit to the RAM allocated to the buffer.
- Leave the config option in the ASCII config UI as it is currently, possibly removing the threads one if we can get it to activate automatically and transparently for the user. The point here is that available RAM and threading depend more on the user's PC than the file itself. So if he configures it on his PC through general settings it would spare having to do the effort for each file, and if the file is transmitted to a colleague with a different machine the settings, which may be wrong, won't be reused.

Now, I'll check the last version and let you know if I see anything worth reporting.

Nicolas

> -----Ursprüngliche Nachricht-----
> Von: kst-bounces at kde.org [mailto:kst-bounces at kde.org] Im Auftrag von Peter
> Kümmel
> Gesendet: Mittwoch, 17. Oktober 2012 09:55
> An: kde-commits at kde.org
> Cc: kst at kde.org
> Betreff: [Kst] branches/work/kst/portto4/kst/src/datasources/ascii
>
> SVN commit 1320843 by kuemmel:
>
> use frame buffer limit as sliding window size

EUROCOPTER DEUTSCHLAND GmbH
Sitz der Gesellschaft / Registered Office: Donauwörth
Registergericht / Registration Court: Amtsgericht Augsburg HRB 16508
Vorsitzender des Aufsichtsrates / Chairman of the Supervisory Board: Dr. Lutz Bertling
Geschäftsführung / Board of Management:
Dr. Wolfgang Schoder, Vorsitzender / CEO; Friedrich-Wilhelm Hormel; Ralf Barnscheidt


CONFIDENTIALITY NOTICE

This communication and the information it contains is intended for the addressee ( s ) named above and for no other persons or organizations.
It is confidential and may be legally privileged and protected by law. The unauthorized use, copying or disclosure of this communication
or any part of it is prohibited and may be unlawful.
If you have received this communication in error, kindly notify us by return e-mail and discard and/or delete the communication.
Thank you very much.
It is possible for e-mails to be intercepted or affected by viruses. Whilst we maintain virus checks on our e-mails, we accept no liability for viruses
or other material which might be introduced with this message.