[Kst] Fwd: branches/work/kst/portto4/kst/src/libkstapp

[Nicolas Brisset]

Hi,

in case it is not clear to everybody: Peter's commit fixes our D&D issues, i.e. we can drop URLs and the file gets opened, or drop a view item and it gets moved:-)
In other words, it solves the issue I introduced when committing file drop support.

So what issues do we have left for 2.0.5? I see the following, since I think Barth was done with the dimensions dialogs:
- matio packaging under Windows including zlib support (Peter has prepared matio, but without zlib which seems to be important enough that it's worth bothering)
- Danyial's performance issues with >38000 vectors, at least an investigation to see whether it's fixable and how
- The crash recently reported when creating vectors through the buttons in the create curve dialog
- an unreported bug in edit multiple curves which I noticed during testing whereby points and line options get mixed. It seems to be an issue in the enablePreferences() function I was planning to try to fix.

As it seems, ASCII-formatted time support in the ASCII source will wait until 2.0.6. 
We also had a couple of problems reported by Matt with nan values in filters, probably also for 2.0.6.

Does that sound realistic? Have I missed something?

Nicolas

----- Mail transféré -----
De: "Peter Kümmel" <syntheticpp at gmx.net>
À: kde-commits at kde.org
Cc: kst at kde.org
Envoyé: Samedi 17 Mars 2012 16:52:10
Objet: [Kst] branches/work/kst/portto4/kst/src/libkstapp

SVN commit 1286129 by kuemmel:

Don't eat drop events of files (urls). 
When accepted it is not passed to the parent.

Qt docu: "The accept flag set with accept(). It is set by default"
http://doc.qt.nokia.com/4.7/qevent.html

 M  +2 -0      scene.cpp  
 M  +0 -2      view.cpp  


--- branches/work/kst/portto4/kst/src/libkstapp/scene.cpp #1286128:1286129
@@ -64,6 +64,8 @@
 {
   if (MimeDataViewItem::downcast(event->mimeData())) {
       event->acceptProposedAction();
+  } else if (event->mimeData()->hasUrls()) {
+    event->ignore();
   }
 }
 
--- branches/work/kst/portto4/kst/src/libkstapp/view.cpp #1286128:1286129
@@ -110,8 +110,6 @@
   connect(this, SIGNAL(viewModeChanged(View::ViewMode)), PlotItemManager::self(), SLOT(clearFocusedPlots()));
 
   applyDialogDefaultsFill();
-
-  setAcceptDrops(false); // Pass event to parent
 }
 
 
_______________________________________________
Kst mailing list
Kst at kde.org
https://mail.kde.org/mailman/listinfo/kst