[Kst] Some details to improve

[Brisset, Nicolas]

Hi,

 

I have started testing the latest changes, and I have just come across
the following small issues when I load an ASCII file:

- the datasource has no scalars, but it appears (empty) in the view
scalars dialog

- vectors don't have string metada, but each vector appears (empty) in
the view strings dialog

- the line containing variable names appears in the datasource strings.
I'd skip it, as I see no way I can use it there.

- the metadata strings (from the datasource) don't appear in the create
label dialog (in the dropdown to insert those awfully long automatic
string names)

- (this time using the sample netCDF file): the datasource-scalar
(base_time) does not appear in the create label dialog (in the dropdown
to insert scalars) although it is in the view scalars dialog

 

Apart from these new points, there is something we have already
discussed. I thought Barth had solved it, but I actually believe it is
still there. The problem is the first page of the datawizard, which
sometimes freezes for a few seconds. 

To test it, just create a directory with a number of very large ASCII
files with names beginning with a common string, and try to select them
in a new kst session (that is, when we don't already have a datasource
object that only gets reused). Below is my analysis of what happens (not
cross-checked with breakpoints in the debugger, I must confess).

When I select a huge ASCII file (>2 million points), before I even have
a chance to click "configure..." it gets parsed, which freezes the UI
for a few long seconds. I suspect the whole file gets parsed already,
which does not make sense at that point. We should wait until the user
clicks "Next". We should only detect the type, which I believe should be
faster than it is. I thought Barth had introduced some mechanism for
that, but I'm not sure it prevents parsing the whole file. I haven't
tested again right now, but I think if you have a couple of large files
in the same directory and scroll through them in the popup that appears
as you type the beginning of the name in the lineedit (assuming you type
it) or as you hover the item in the file dialog (assuming you use the
dialog through the button on the right), each time one gets selected it
triggers the textChanged() signal, which triggers the validate() slot,
which parses the whole file.

 

I'll continue testing and I'll report what I find along the way, so that
it can be addressed.

 

Nicolas 

 



Eurocopter Deutschland GmbH
Sitz der Gesellschaft/Registered Office: Donauwoerth
Registergericht/Registration Court: Amtsgericht Augsburg HRB 16508
Vorsitzender des Aufsichtsrates/Chairman of the Supervisory Board: Dr. Lutz Bertling
Geschaeftsfuehrung/Board of Management:
Dr. Wolfgang Schoder, Vorsitzender/CEO; Friedrich-Wilhelm Hormel; Ralf Barnscheidt

CONFIDENTIALITY NOTICE 

This communication and the information it contains is intended for the addressee(s) named above and for no other persons or organizations. It is confidential and may be legally privileged and protected by law. The unauthorized use, copying or disclosure of this communication or any part of it is prohibited and may be unlawful. 
If you have received this communication in error, kindly notify us by return e-mail and discard and/or delete the communication. Thank you very much. 
It is possible for e-mails to be intercepted or affected by viruses. Whilst we maintain virus checks on our e-mails, we accept no liability for viruses or other material which might be introduced with this message. 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kst/attachments/20110128/354109a8/attachment-0001.htm