[Kst] branches/work/kst/portto4/kst

[Barth Netterfield]

SVN commit 1130586 by netterfield:

Fix loading of shared axis boxes
Fix resizing of shared axis boxes



 M  +7 -10     devel-docs/Kst2Specs/Bugs  
 M  +3 -1      src/libkstapp/sharedaxisboxitem.cpp  
 M  +2 -0      src/libkstapp/sharedaxisboxitem.h  
 M  +0 -1      src/libkstapp/view.cpp  
 M  +0 -2      src/libkstapp/viewgridlayout.cpp  


--- branches/work/kst/portto4/kst/devel-docs/Kst2Specs/Bugs #1130585:1130586
@@ -9,9 +9,10 @@
 
 Curves are rendered slightly above where they should be.  Take a plot
 that it is of very boring data (like always exactly zero) and it'll be
-drawn one pixel above the axis tick mark for zero.  
-  (Ticks and curves use different rounding)
+drawn one pixel above the axis tick mark for zero.  (This is not always the same - sometimes above, sometimes below, sometimes right.)
+So: it appears that ticks and curves use different rounding
 
+Probably related bug: points don't always appear centered on the line.
 --------------------
 
 Windows MEMleak
@@ -47,13 +48,9 @@
 scalar will indicate a value strikingly similar to the "Min" (or perhaps
 "First") value on the plot rather than the Last value.
 
-------------------------
+----------------------
 
-Resizing with shared axis box doesn't resize borders
+'z' mode with shared axis messes up:
+  -still draws unneeded plots
+  -doesn't draw hidden axis.
 
--------------------------
-
-Loading a file with a shared axis box:
-  background black
-  no 'break shared axis' option in menu
-
--- branches/work/kst/portto4/kst/src/libkstapp/sharedaxisboxitem.cpp #1130585:1130586
@@ -1270,7 +1270,9 @@
         Q_ASSERT(rc);
         if (!rc->parse(xml, validTag) && validTag) {
           ViewItem *i = GraphicsFactory::parse(xml, store, view, rc);
-          if (!i) {
+          if (PlotItem *plotItem = qobject_cast<PlotItem*>(i)) {
+            plotItem->setSharedAxisBox(rc);
+            rc->_sharedPlots << plotItem;
           }
         }
       }
--- branches/work/kst/portto4/kst/src/libkstapp/sharedaxisboxitem.h #1130585:1130586
@@ -22,6 +22,8 @@
 {
   Q_OBJECT
   public:
+    friend class SharedAxisBoxItemFactory;
+
     SharedAxisBoxItem(View *parent);
     virtual ~SharedAxisBoxItem();
 
--- branches/work/kst/portto4/kst/src/libkstapp/view.cpp #1130585:1130586
@@ -353,7 +353,6 @@
 
 }
 
-
 void View::processResize(QSize size) {
 
   setPlotBordersDirty(true);
--- branches/work/kst/portto4/kst/src/libkstapp/viewgridlayout.cpp #1130585:1130586
@@ -234,12 +234,10 @@
       if (!viewItem || !viewItem->isVisible())
         continue;
       if (PlotItem *plotItem = qobject_cast<PlotItem*>(viewItem)) {
-        if (!plotItem->isInSharedAxisBox()) {  // Let the box worry about itself.
           plotItems.append(plotItem);
         }
       }
     }
-  }
 
 #if DEBUG_PLOT_STANDARDIZATION
   qDebug() << "Ready to standarize" << plotItems.count() << "plots";