[Kst] branches/work/kst/portto4/kst/src/libkstapp

Barth Netterfield netterfield at astro.utoronto.ca
Tue May 25 00:58:00 CEST 2010


SVN commit 1130281 by netterfield:

Ran krazy checker - there are over 1000 issues, most of which are 'real'.  IIRC, a clean krazy check
is required for KDE apps, so these will have to be fixed eventually.

I've randomly fixed a handful in the process of understanding them.



 M  +2 -2      applicationsettings.cpp  
 M  +1 -1      arrowitemdialog.h  
 M  +1 -1      bugreportwizard.cpp  
 M  +1 -1      commandlineparser.cpp  
 M  +1 -1      labelrenderer.cpp  


--- branches/work/kst/portto4/kst/src/libkstapp/applicationsettings.cpp #1130280:1130281
@@ -281,9 +281,9 @@
       _gradientStops.append(qMakePair(point, color));
 
       stopList += QString::number(point);
-      stopList += ",";
+      stopList += ',';
       stopList += color.name();
-      stopList += ",";
+      stopList += ',';
     }
   }
   _settings->setValue("fill/gradient", stopList);
--- branches/work/kst/portto4/kst/src/libkstapp/arrowitemdialog.h #1130280:1130281
@@ -25,7 +25,7 @@
 {
   Q_OBJECT
   public:
-    ArrowItemDialog(ArrowItem *item, QWidget *parent = 0);
+    explicit ArrowItemDialog(ArrowItem *item, QWidget *parent = 0);
     virtual ~ArrowItemDialog();
 
   private Q_SLOTS:
--- branches/work/kst/portto4/kst/src/libkstapp/bugreportwizard.cpp #1130280:1130281
@@ -25,7 +25,7 @@
 
   setupUi(this);
 
-  _kstVersion->setText(i18n("%1").arg(KSTVERSION));
+  _kstVersion->setText(KSTVERSION);
 
 #if defined(Q_OS_MAC9)
   _OS->setText("Mac OS 9");
--- branches/work/kst/portto4/kst/src/libkstapp/commandlineparser.cpp #1130280:1130281
@@ -114,7 +114,7 @@
 static void printUsage(QString t) { // No console on Windows.
     QString displayText(usageMessage);
     if (!t.isEmpty()) {
-      displayText += "\n";
+      displayText += '\n';
       displayText += t;
     }
     QMessageBox box(QMessageBox::Information, "Kst", displayText);
--- branches/work/kst/portto4/kst/src/libkstapp/labelrenderer.cpp #1130280:1130281
@@ -88,7 +88,7 @@
     }
 
     if (!rc.substitute && (fi->scalar || fi->vector)) {
-      QString txt = QString("[") + fi->text + "]";
+      QString txt = QString('[') + fi->text + ']';
       if (rc.p) {
         rc.p->drawText(rc.x, rc.y, txt);
       }


More information about the Kst mailing list