[Kst] kst2 datasource API comments

[Barth Netterfield]

There are two frameCount in struct Optional, frameCount and vectorframeCount.

The data sources you ported only set frameCount, so dataVector::fileLength() 
didn't work.

I see two paths: 

1) we state that frameCount is purely a vector concept, and get rid of 
vectorframeCount.

2) we imagine that there could be data sources that, eg, have a list of 
matrixes, and so we might have a matrixframeCount, vectorframeCount, etc.

If (2) is the case, I think we would have to do even more API work for this to 
make sense...

Currently frameCount is only used for vectors, so I'm going to suggest option 
1: get rid of vectorframeCount, and only use frameCount.

cbn


On Saturday 20 March 2010 15:17:54 Peter Kümmel wrote:
> Peter Kümmel wrote:
> >> If I understand it, I think I like it.
> > 
> > OK, when there are no objection from others (Nicolas?) then I will
> > do the move. Not identical to above (I think it is better to define
> > SourceInterface within DataSource and to find a other name; using getters
> > and setters; ...)
> 
> Done. qimagesource.cpp is the best file to show how it now looks like:
> http://websvn.kde.org/branches/work/kst/portto4/kst/src/datasources/qimages
> ource/qimagesource.cpp?revision=1105620&view=markup
> 
> In asciisource and dirfilesource the new interface code only wraps the old
> one.
> 
> Peter
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst