[Kst] branches/work/kst/portto4/kst/src

Peter Kümmel syntheticpp at yahoo.com
Sat Mar 13 02:09:30 CET 2010


SVN commit 1102609 by kuemmel:

Fix for http://bugs.kde.org/show_bug.cgi?id=225347

The UpdateManager doesn't resolve dependencies, and the update order 
seems to be different on the platforms.

In this case here the equation must first fill the vectors and update them
which then will be used by the curve.

Maybe there are other places with the same bug.

 M  +2 -2      libkstapp/equationdialog.cpp  
 M  +3 -3      libkstmath/equation.cpp  


--- branches/work/kst/portto4/kst/src/libkstapp/equationdialog.cpp #1102608:1102609
@@ -292,7 +292,7 @@
   }
 
   equation->writeLock();
-  equation->registerChange();
+  equation->internalUpdate();
   equation->unlock();
 
   CurvePtr curve = _document->objectStore()->createObject<Curve>();
@@ -311,7 +311,7 @@
   curve->setBarStyle(_equationTab->curveAppearance()->barStyle());
 
   curve->writeLock();
-  curve->registerChange();
+  curve->internalUpdate();
   curve->unlock();
 
   _equationTab->curveAppearance()->setWidgetDefaults();
--- branches/work/kst/portto4/kst/src/libkstmath/equation.cpp #1102608:1102609
@@ -126,9 +126,9 @@
 
   _isValid = FillY(true);
 
-  // these should be updated by the update manager
-  //_yOutVector->update();
-  //_xOutVector->update();
+  //  should this be updated by the update manager?
+  _yOutVector->internalUpdate();
+  _xOutVector->internalUpdate();
 
   unlockInputsAndOutputs();
 


More information about the Kst mailing list