[Kst] [Bug 234403] Equation is corrupted upon changing data file

[Andrew Walker]

https://bugs.kde.org/show_bug.cgi?id=234403





--- Comment #1 from Andrew Walker <arwalker sumusltd com>  2010-04-16 02:39:34 ---
The problem is caused by KstObjectCollection::doRename()

This function is responsible for tearing down the tag, changing the name, and
then building up the newly named tag.

However, the call to change the tag's name (KstObject::setTagName()), emits the
signal tagChanged. This causes any equation using the tag to be reparsed, but
the tag being renamed has not yet been rebuilt, so it is not found.

The equation will still work, but the rebuilt text of the equation will be
invalid as a result. Thus saving the session and reloading will result in an
invalid equation.

The solution is to emit the tagChanged signal at the correct time.

An even better solution would be to hold off on reparsing any equations until
all the tags had been renamed, being considerably more efficient.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.