[Kst] Fwd: [Bug 142895] Over sampling of data gives misleading information

[George Staikos]

A few comments:

setInterp() should not setDirty if the value doesn't change to avoid  
an update run.

setInterp is an awful name. :-)

The new strings will cause translation impact.

Beyond that I think it's okay, assuming that the combo can never be  
empty (if I understand it correctly).


On 16-Mar-07, at 2:38 PM, Barth Netterfield wrote:

>
> ----------  Forwarded Message  ----------
>
> Subject: [Bug 142895] Over sampling of data gives misleading  
> information
> Date: Friday 16 March 2007
> From: netterfield at astro.utoronto.ca
> To: netterfield at astro.utoronto.ca
>
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=142895
>
>
>
>
> ------- Additional Comments From netterfield astro utoronto ca   
> 2007-03-16
> 15:29 -------
> Created an attachment (id=19996)
>  --> (http://bugs.kde.org/attachment.cgi?id=19996&action=view)
> Proposed fix
>
> Here is a patch: most of the invasiveness is UI.
>
> -It adds to the curve dialog a combobox to set the interpolation  
> policy:
> Y axis, X axis, highest resolution, and lowest resolution.  A combo  
> box was
> used because radio buttons don't have a tri-state option.
>
> -The default in the UI is now 'Y axis' rather than highest  
> resolutions: this
> alone would have 'fixed' the behavior reported in the bug.  
> Older .kst files
> get
> read as highest resolution, which was the old method.
>
> No stickyness has been added to the new curve dialog.
>
> Some questionable points:
> -kstvcurve uses an enum for the mode.  The UI casts the enum value  
> from the
> order in the combo box - so... if someone changes the order of  
> options in the
> combo, things will break.  Alternatives are messy.
>
> -------------------------------------------------------
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst

--
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/