[Kst] [Bug 143027] Crash when removing scalars with View Scalar Values dialog open

George Staikos staikos at kde.org
Fri Mar 16 00:32:11 CET 2007


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=143027         
staikos kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From staikos kde org  2007-03-16 00:32 -------
SVN commit 642969 by staikos:

Keep track of deleted nodes.  Unfortunately this makes the tree "heavy" as it
requires all ndoes to be QObjects but there is no other way that is this clean
and non-intrusive.  Reviewed by Eli.

BUG: 143027


 M  +1 -1      libkst/kstobjectcollection.h  
 M  +1 -1      libkstapp/kstscalarlistview.h  
 M  +1 -1      libkstapp/kststringlistview.h  


--- trunk/extragear/graphics/kst/src/libkst/kstobjectcollection.h #642968:642969
 @ -44,7 +44,7  @
 
 /** KstObject Naming Tree */
 template <class T>
-class KstObjectTreeNode {
+class KstObjectTreeNode : QObject {
   public:
     KstObjectTreeNode(const QString& tag = QString::null);
     ~KstObjectTreeNode();
--- trunk/extragear/graphics/kst/src/libkstapp/kstscalarlistview.h #642968:642969
 @ -49,7 +49,7  @
   private:
     void commonConstructor();
 
-    KstObjectTreeNode<KstScalar> *_node;
+    QGuardedPtr<KstObjectTreeNode<KstScalar> > _node;
 };
 
 #endif
--- trunk/extragear/graphics/kst/src/libkstapp/kststringlistview.h #642968:642969
 @ -46,7 +46,7  @
     KstObjectTreeNode<KstString> *node() const { return _node; }
 
   private:
-    KstObjectTreeNode<KstString> *_node;
+    QGuardedPtr<KstObjectTreeNode<KstString> > _node;
 };
 
 #endif


More information about the Kst mailing list