[Kst] The problem with auto-sizing labels
George Staikos
staikos at kde.org
Tue Jan 23 20:18:00 CET 2007
Mandatory auto-sizing of labels is a bit of an issue. Justification
(horizontal) is actually useful with the current design, however.
Place a label to the right edge of the view and put dynamic content
in it (scalar/strings). Those can cause the label to grow, but it
can't grow because it's already right-aligned. Therefore we
presently use justify-centre. My feeling is we should generally
justify-left, however there could be sessions where it makes more
sense to justify-right. In fact resizing labels due to content
changing is horribly ugly in my opinion. It can destroy the layout
of a session entirely. Therefore I'm going to revert this change and
I think we need to reconsider label sizing once again.
On 5-Jan-07, at 7:21 PM, Andrew Walker wrote:
> Possibly, but not as easy as removing it.
>
> And a smaller patch than fixing it so hopefully less likely to get
> clobbered
> when you merge your branch.
>
> On January 5, 2007 3:55 pm, George Staikos wrote:
>> On 5-Jan-07, at 6:33 PM, Andrew Walker wrote:
>>> SVN commit 620422 by arwalker:
>>>
>>> BUG:135437 Remove the horizontal justifcation item as it is non-
>>> functional given the new behaviour for labels.
>>>
>>> M +0 -4 kstviewlabel.cpp
>>> M +101 -66 viewlabelwidget.ui
>>> M +0 -3 viewlabelwidget.ui.h
>>
>> Why did you decide to remove it instead of fixing it? It's easy
>> enough to support I think.
>>
>> Also I noticed that you have been making numerous checkins
>> lately. Please beware that we have a huge branch ready to merge.
>> Large patches will make this difficult and given a choice between a
>> long difficult merge or an overwrite, we will clobber changes in
>> trunk. We spent far too long merging the branch already. It would
>> be best to keep us informed of what you woud like or intend to do in
>> trunk.
--
George Staikos
KDE Developer http://www.kde.org/
Staikos Computing Services Inc. http://www.staikos.net/
More information about the Kst
mailing list