[Kst] extragear/graphics/kst/src/datasources/qimagesource

Eli Fidler eli at staikos.net
Mon Feb 26 23:45:46 CET 2007


I think the second change (the .isEmpty()) breaks the build. My Qt3 docs say 
QImage::imageFormat(filename) returns a char *, not a QByteArray like in Qt4.

Eli

On February 22, 2007 17:57:40 George Staikos wrote:
> SVN commit 636383 by staikos:
>
> correct two issues found during porting - in particular a search of the
> wrong string
>
>
>  M  +2 -2      qimagesource.cpp
>
>
> ---
> trunk/extragear/graphics/kst/src/datasources/qimagesource/qimagesource.cpp
> #636382:636383 @@ -247,7 +247,7 @@
>    if ( ftype.isEmpty() ) return 0;
>
>    if ( ftype == "TIFF" ) {
> -    if ( ftype.find( ".tif",  -5, false )<0 ) return 0;
> +    if ( filename.find( ".tif",  -5, false )<0 ) return 0;
>    }
>
>    return 90;
> @@ -266,7 +266,7 @@
>    if (typeSuggestion) {
>      *typeSuggestion = "QImage compatible Image";
>    }
> -  if ( QImage::imageFormat( filename ) ) {
> +  if ( !QImage::imageFormat( filename ).isEmpty() ) {
>      fieldList.append("INDEX");
>      fieldList.append( "GRAY" );
>      fieldList.append( "RED" );
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst




More information about the Kst mailing list